need help on programming a pic16f877a

[rossu704]

i'm having some trouble wif my pic;

i use pin A0 and pin A1 as my inputs.
when a voltage of 2-5 volts is detected at either input, pic should give an output to a dtmf telephone to dial a certain number.

i have completed the programing its just that the pic still give output (dial the phone) even when no voltage is detected at the inputs, during this time the voltage is 0.102V. if any voltage ranging from 2-5 V is detected at either the input, output should be send out to dial the telephone.

so, can anyone point out the solution for me.
below is the c code i've written, feel free to correct any mistakes

https://www.electro-tech-online.com/attachments/programming-pic-c.12282/

 

[BeeBop]

Hi, I just took a QUICK look at your source file, and saw one place which is giving you trouble:

else
{
while (x = 2)
{ test();
++x;
}

}

You are assigning the value of 2 to x, and I think you want:
while(x==2)

I didn't look much further, though.

 

[rossu704]

ohh tenks alot ..silly me

 

[JimFranklin]

... (paraphrased actually)

while(x==2)

instead of
while(x = 2)

That was my single most common mistake when I started learning C.