need to include a GOTO sub routine or BRA?
the first routine is the sound. second routine checks for daylight on input B#?(photo transistor on BR2 is good choice?)disable PIR
third routine sets timer into gear for 20 minutes if daylight is present(if BR2 is high or low?)
I want to read status of photo transistor then disable PIR and enable timer if daylight is present. otherwise enable PIR and disable timer.
need to goto sub routines as needed?
how to do a sub routine??

Code:

Device = 18F1320
Clock = 8 // 8MHz clock
Config OSC = INTIO2, WDT = OFF, LVP = OFF
Include "Utils.bas"
Dim but As PORTB.0
Dim led As PORTA.0

Dim NOT_RBPU As INTCON2.7
Dim TMR1IE As PIE1.0
Dim TMR1IF As PIR1.0
Dim TMR1 As TMR1L.AsWord
Dim Speaker As PORTB.3
Dim SpeakerTris As TRISB.3

Dim Amp As PORTB.1 // turns on amp power
Dim AmpTris As TRISB.1//turns on amp pin 9
Dim Speed As Word
Dim dip1 As PORTA.0

Dim dip2 As PORTA.1

Dim dip3 As PORTA.2

Dim dip4 As PORTA.3

Dim dipRD As PORTB.0

//global variables
Dim Seed As LongWord, Tone As Byte
Dim i As Byte

//half period delays = clock speed divided by 2*frequency
Const Tones(18) As Word = (2000000/12000,2000000/10000,2000000/8000,2000000/6000,2000000/4000,1000,
2000000/12000,2000000/10000,2000000/8000,2000000/6000,2000000/4000,1000,2000000/12000,2000000/10000,2000000/8000,2000000/6000,2000000/4000,1000)

//interrupt routine
Interrupt MyInt()
          T1CON.0=0 //stop timer
          TMR1=-Tones(Tone) //reset period
          T1CON.0=1 //restart timer
If Tone=5 Then //if silence
   Speaker=0 //speaker off
Else //otherwise
Toggle(Speaker) //make sound

EndIf
TMR1IF=0 //clear interrupt flag
End Interrupt

Function Rand(Range As Byte) As Byte
Dim i As Byte, feed As Bit, temp As Word
For i = 0 To 7 //generate 8 bits
    Feed = Seed.30 Xor Seed.27 //make new bit
    Seed=Seed*2+Feed //shift seed left and add new bit
Next
    Temp=(Seed And 255) * Range //change Rand from 0 to 255
    Rand = Temp/256 //to 0 to (Range-1)
End Function

//main code starts here


      




       OSCCON = $72            //select 8MHz internal clock
       NOT_RBPU=0              //WPUs on port B
       ADCON1=$7f              //all digital
       TRISB.0=0               //make output
       PORTB.0=1 //makes pin 8 high for dip switches
       T1CON = %10000001       //pre=1
       T1CON = %10000001 //pre=1
       Tone=5 //no sound please
       TMR1IE=1 //enable timer 1 interrupt
Enable(MyInt) //set interrupt going
SpeakerTris=0 //Setup Port
Seed=$12345678 //seed random number
        TRISA =%00001111          //sets your inputs on porta 
While(TRUE) //repeat forever

    If dip1=1 Then //dip1 pin 1
       Speed=25
    EndIf
    
    If dip2=1 Then // dip 2 pin 2
       Speed=50 
    EndIf
    
    If dip3=1 Then //dip3 pin 6
       Speed=75
    EndIf
    
    If dip4=1 Then //dip4 pin 
       Speed=Rand(10)*15+15    //Speed = 25 to 250 random select speed
       
    EndIf
  checks status of BR2=daylight or dark 
If PORTB.1=0 Then //if button 1 pressed add PIR=1 here
else
 PORTB.2=0 Then bra //jump to timer sub routine
For i = 1 To 200 //play 20 tones
    Tone=Rand(5) //each tone is random frequency
DelayMS(Speed) //and for 1.00 seconds
Next //end for loop
Else //otherwise
     Tone=5 //silence
     i=Rand(255) //make rand more random
EndIf //end if condition
Wend //end of while loop
//PIR disable routine



SetAllDigital      //set digital so you can read RB0 or it will always read low
TRISA =%00000000  // if your using the junebug This is fool proof to get a led to lite
PORTA =%00000000  // Set's it all low
TRISB =%00000001  // Set's inputs and outputs 
PORTB =%00000000   // Set's it all low
INTCON2.7=0        // sets wpu on portb turns on pullups on PORTB
OSCCON = $72            // 8 MHz clock
While true              // this loops it so it keeps checking 
If but = 0 Then        // checks button 1 on the junebug to see if low
    led =0                 // Turns off led
    DelayMS(10)       // small debounce delay
ElseIf but = 1 Then  // checks button 1 on the junebug to see if high(BR2)
   led =1                 // Turns on led
   DelayMS(10)       // small debounce delay
EndIf                     // closes your IF THEN statements 
Wend

End
// timer sub routine


Include "ISRTimer.bas"          

// constant ID to 4 * 16 bit timers...
Const
   Timer1 = 0,
  
   Timer4 = 3
      
// OnTimer1 event...
Event OnTimer1()
   Toggle(PORTB.0)//pin 8
End Event
Event OnTimer2()
   Toggle(PORTB.1)//pin 9
End Event




// activate the timer module...
Timer.Initialize

// initialise the timers - refresh every 1000Hz (1ms)...
Timer.Items(Timer1).Interval = 50        // 50ms
Timer.Items(Timer1).OnTimer = OnTimer1   // timer event handler

  // timer event handler
Timer.Items(Timer4).Interval = 2000      // 2000ms, no event handler
                                         // about 20 minutes

// enable the timers...
Timer.Items(Timer1).Enabled = true

Timer.Items(Timer4).Enabled = true

// start processing all timers...
Timer.Start

// main program loop...
While true
   // this is a polled timer, not event driven - check to see
   // if it has timeout...
   If Not Timer.Items(Timer4).Enabled Then
      Toggle(PORTB.0)//pin 8
      Toggle(PORTB.1)//pin 9
      Timer.Items(Timer4).Enabled = true
   EndIf
   Toggle(PORTB.1)//pin 8   
 
Wend

have seen BRA in swordfish basic which this code is.
wondering if I need it or ?? seeing how I basically have one main program and two sub programs
main=the random sound that was originally triggered by the PIR but IR doesn't work in daylight(the PIR sensor takes RB1 LOW)
sub 1 = is it daylight or night (a photo transistor takes a designated pin LOW or HIGH?
sub 2=a timer that triggers the sound every 20 minutes if its daylight.
I would like to use a SLEEP mode to conserve battery power as well.
I got all three programs working seperatly but now I copied n pasted all together.

Nearly all Basics (even VB) contain the goto function but its use is frowned upon. When you use goto you end up with spaghetti like code that is very hard to follow.

Learn to use the more structured commands like while..wend, repeat...until, for...next, if...endif etc. Also, use correct indenting. It will make your code much easier to follow.

Mike.

Will research in swordfish help.
hopfully I can straighen the code out.

here is my work in progress. not pretty but still moving things around so I need no sub routines (don't want spagetti)
the tabs etc? what is the perfered layout?
I am attempting to comment and seperate the different routines.
one for sound
one for timer,
one for daylight/disable PIR night time/enable PIR
finding its diffcult to locate duplicate items as I copy n paste alot. lose track where I am at.
wish the left side gutter had a search function I don't know about. It shows some but not all??

Code:

Device = 18F1320
Clock = 8 // 8MHz clock
Config OSC = INTIO2, WDT = OFF, LVP = OFF
Include "Utils.bas"
Include "ISRTimer.bas" 
Dim but As PORTB.2 //input for photo diode day disable
Dim led As PORTb.4//triggers PIC inplace of PIR

Dim NOT_RBPU As INTCON2.7
Dim TMR1IE As PIE1.0
Dim TMR1IF As PIR1.0
Dim TMR1 As TMR1L.AsWord
Dim Speaker As PORTB.3
Dim SpeakerTris As TRISB.3

Dim Amp As PORTB.1 // turns on amp power
Dim AmpTris As TRISB.1//turns on amp pin 9
Dim Speed As Word
Dim dip1 As PORTA.0
//dip switch settings
Dim dip2 As PORTA.1

Dim dip3 As PORTA.2

Dim dip4 As PORTA.3

Dim dipRD As PORTB.0
Const
     Timer1 = 0,
     
     Timer4 = 3

//global variables
Dim Seed As LongWord, Tone As Byte
Dim i As Byte

//half period delays = clock speed divided by 2*frequency
Const Tones(18) As Word = (2000000/12000,2000000/10000,2000000/8000,2000000/6000,2000000/4000,1000,
2000000/12000,2000000/10000,2000000/8000,2000000/6000,2000000/4000,1000,2000000/12000,2000000/10000,2000000/8000,2000000/6000,2000000/4000,1000)
//******************************************
//++++++++++++++++++++++++++++++++++++++++++
//interrupt routine
Interrupt MyInt()
          T1CON.0=0 //stop timer
          TMR1=-Tones(Tone) //reset period
          T1CON.0=1 //restart timer
If Tone=5 Then //if silence
   Speaker=0 //speaker off
Else //otherwise
Toggle(Speaker) //make sound

EndIf
TMR1IF=0 //clear interrupt flag
End Interrupt

Function Rand(Range As Byte) As Byte
Dim i As Byte, feed As Bit, temp As Word
For i = 0 To 7 //generate 8 bits
    Feed = Seed.30 Xor Seed.27 //make new bit
    Seed=Seed*2+Feed //shift seed left and add new bit
Next
    Temp=(Seed And 255) * Range //change Rand from 0 to 255
    Rand = Temp/256 //to 0 to (Range-1)
End Function
//+++++++++++++++++++++++++++++++
//+++++++++++++++++++++++++++++++      


//main code starts here

       OSCCON = $72            //select 8MHz internal clock
       NOT_RBPU=0              //WPUs on port B
       ADCON1=$7f              //all digital
       TRISB.0=0               //make output
       PORTB.0=1 //makes pin 8 high for dip switches
       T1CON = %10000001       //pre=1
       T1CON = %10000001 //pre=1
       Tone=5 //no sound please
       TMR1IE=1 //enable timer 1 interrupt
Enable(MyInt) //set interrupt going
SpeakerTris=0 //Setup Port
Seed=$12345678 //seed random number
        TRISA =%00001111          //sets your inputs on porta 
While(TRUE) //repeat forever

If     dip1=1 Then //dip1 pin 1
       Speed=25
EndIf
    
If     dip2=1 Then // dip 2 pin 2
       Speed=50 
EndIf
    
If     dip3=1 Then //dip3 pin 6
       Speed=75
EndIf
    
If     dip4=1 Then //dip4 pin 
       Speed=Rand(10)*15+15    //Speed = 25 to 250 random select speed
       
EndIf
If    but = 0 Then        // checksFOR DAYLIGHT CONDITION on pin 17 B2
      led =1                 // takes pin 10 HIGH
DelayMS(10)       // small debounce delay
        led=0     // pin 10 low
        
        
//+++++++++++++++++
//timer routine daylight condition
//++++++++++++++++++

          

// constant ID to 4 * 16 bit timers...
//Const
     //Timer1 = 0,
     
   //  Timer4 = 3
      
// OnTimer1 event...
Event OnTimer1()
      PORTB.2=1//pin 17= 
      //daylight present triggers timer
End Event

// activate the timer module...
   Timer.Initialize

// initialise the timers - refresh every 1000Hz (1ms)...
   Timer.Items(Timer1).Interval = 50        // 50ms
   Timer.Items(Timer1).OnTimer = OnTimer1   // timer event handler

  // timer event handler
  Timer.Items(Timer4).Interval = 2000      // 2000ms, no event handler
                                         // about 20 minutes// enable the timers...
   Timer.Items(Timer1).Enabled = true

   Timer.Items(Timer4).Enabled = true

// start processing all timers...
   Timer.Start

// main program loop...
While true
   // this is a polled timer, not event driven - check to see
   // if it has timeout...
If Not Timer.Items(Timer4).Enabled Then
      Toggle(PORTB.4)//pin 10 for testing
      Toggle(PORTB.1)//pin 9
      Timer.Items(Timer4).Enabled = true
EndIf
   Toggle(PORTB.1)//pin 8   
 
Wend

//+++++++++++++
 // DARK ROUTINE PIR enabled
 //++++++++++++++++  
If     PORTB.1=0 Then //PIr ENABLED = DARK pin 9
For    i = 1 To 200 //play 20 tones
       Tone=Rand(5) //each tone is random frequency
DelayMS(Speed) //and for 1.00 seconds
Next //end for loop




EndIf                     // closes your IF THEN statements 

Else //otherwise
       Tone=5 //silence
       i=Rand(255) //make rand more random
EndIf //end if condition
Wend //end of while loop




EndIf                     // closes your IF THEN statements 
Wend

End

to do it like tht. remember I am really new at this.
I contemplated making each function a module but creating each module ??
question=you designate a byte as light etc.
this is assume is same as say light = 1. night = 2 etc.
if X = 1 then its light or X = 2 its dark
this byte syntax ???
takes less memory code or ??
looking at your code If day = light then PlaySound
playsound then is same as a subroutine? just a different way to go instead of a goto or ??

will rewrite as suggested as I have each function in separate programs.
your method looks so much easier.