I'm not using a wall adapter, I'm using a battery (7AH sealed lead acid).

Code:

#include <system.h>
#pragma DATA _CONFIG, _CP_OFF & _LVP_OFF & _BODEN_OFF & _PWRTE_OFF & _WDT_OFF & _XT_OSC


void test(unsigned char data) //stolen from a website, I can't remember where now
{
   unsigned char bits;
   for (bits=0x80; bits != 0; bits >>= 1)
   {
      if ((bits & data) == bits)  
      {     
          set_bit(portb,0);
      }
      else
      {
         clear_bit(portb, 0);
      }
      set_bit(portb, 1);   
      clear_bit(portb, 1);
   }
   set_bit(portb, 2);        
	clear_bit(portb, 2);
} 

void main()
{
	trisb = 0;
	portb = 0;
	unsigned char f = 0;
	
	while(1)
	{
		toggle_bit(f, 5);
		test(f);
		delay_s(1);
	} 
}

try:

Code:

void test(unsigned char data) //stolen from a website, I can't remember where now
{
   unsigned char x;
   for (x=0;x<8;x++)
   {
      if (data & 0x80) != 0)
          set_bit(portb,0);
      else
         clear_bit(portb, 0);

      set_bit(portb, 1);
      clear_bit(portb, 1);\

      data=data<<1;
   }
   set_bit(portb, 2);        
   clear_bit(portb, 2);
}

Originally Posted by AtomSoft

try:

Code:

void test(unsigned char data) //provided by atomsoft
{
   unsigned char bits,x;
   for (x=0;x<8;x++)
   {
      if (data & 0x80) != 0)
          set_bit(portb,0);
      else
         clear_bit(portb, 0);

      set_bit(portb, 1);
      clear_bit(portb, 1);
   }
   set_bit(portb, 2);        
   clear_bit(portb, 2);
}

That would not work because you're only testing the 8th bit. The function I have works fine, I have tested all the LEDs in different combinations.

forgot the shift i see I fixed tho..

So since it works fine whats the issue.

danielsmusic,
You need at least 0.33uF on the input and 0.1uF on the output of the 7805 or it may become unstable. Put them as close as possible to the 7805. You should also have a 0.1uF close to the PICs power pins.

Off Topic!

When I design sign boards I first choose correct high efficiency LED's or LED Matrixes.So I can drive them with a low duty cycles later to minimize the power consumption without notifying any brightness changing situations.

Originally Posted by kchriste

danielsmusic,
You need at least 0.33uF on the input and 0.1uF on the output of the 7805 or it may become unstable. Put them as close as possible to the 7805. You should also have a 0.1uF close to the PICs power pins.

Yes, this is why we asked for the COMPLETE circuit, and it shows a complete lack of required capacitors - you need a capacitor on the input pin of the 7805 as well, and a good size electrolytic across the battery.

I did initially have a capacitor either side of the regulator. I noticed that it seems to slow down the clock speed on the PIC so I removed them.

EDIT: Only tried >1uF cap on output, I will try the recommended 0.1uf when I get home. And some across the battery.

Adding any sort of capacitor anywhere in the circuit completely stops the PIC and it does nothing.

Originally Posted by petrv

If adding a capacitor between +5V and 0V (power supply) stops it from working then I guess your circuit must have much more serious problem than it seems.

With a very large capacitor across the battery terminals it will stay flashing a bit longer than without any capacitors at all. Although having the same capacitor across 5v and 0v it won't work at all.

What voltage is the battery?
What voltage does the volt meter show for the battery?

You really should post the schematic for this thing starting with the battery. It could save a lot of time and posts.

A picture that was good enough to follow the wiring would be good too.

Originally Posted by 3v0

What voltage is the battery?

12V

Originally Posted by 3v0

What voltage does the volt meter show for the battery?

13V

Originally Posted by 3v0

You really should post the schematic for this thing starting with the battery. It could save a lot of time and posts.

I posted a picture a bit further up.


EDIT: Here's something interesting, if I hold an output pin on the PIC high with a small load (LED), it works with a 0.1uF capacitor across the battery, but as I add more across the IC etc it will slow down the PIC although the pattern is still there.

Take a photo of your device, with the caps. Why are you using a shift register why not just drive the LEDs directly from the PIC?
PS the 74HC595 can only source a couple of mA (it can sink more than it can source) Your LEDs need about 470ohms if you wish to drive them from the 74HC595.